Skip to content

Downgraded skips in tests #6716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 13 commits into from
Jan 15, 2026
+66 −107
Merged

Downgraded skips in tests #6716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4e658db
Downgraded skips in tests
terryluan12 Jan 12, 2026
59b0be2
Fixed failing tests
terryluan12 Jan 13, 2026
6c3ee49
Fixed test_ftplib + test_socket + test_ssl + test_threaded_import fai…
terryluan12 Jan 13, 2026
55665b7
Removed comments about which tests are run in which environment
terryluan12 Jan 13, 2026
4c1dd38
Addressed PR comments
terryluan12 Jan 13, 2026
87fa39d
Annotated skips on failing tests
terryluan12 Jan 13, 2026
e0fa426
Removed unneeded tests
terryluan12 Jan 13, 2026
46677e7
Removed unneeded sys import from test_ftplib
terryluan12 Jan 13, 2026
96daa90
Added annotation to test_ftplib
terryluan12 Jan 13, 2026
4f86cbf
Readded skipIf to test_cleanup_with_symlink_modes with a more general…
terryluan12 Jan 14, 2026
d5035f4
Addressed PR comments
terryluan12 Jan 14, 2026
6a3932d
Made changes to minimize diff in PR
terryluan12 Jan 14, 2026
6b57027
Apply suggestion from @youknowone
youknowone Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_ast/test_ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2396,7 +2396,7 @@ def test_stdlib_validates(self):
ast.MatchMapping([], [], rest="_"),
]

@unittest.skip("TODO: RUSTPYTHON; thread 'main' panicked")
@unittest.expectedFailure # TODO: RUSTPYTHON
def test_match_validation_pattern(self):
name_x = ast.Name("x", ast.Load())
for pattern in self._MATCH_PATTERNS:
Expand Down
68 changes: 33 additions & 35 deletions Lib/test/test_bdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ def fail(self, msg=None):
class StateTestCase(BaseTestCase):
"""Test the step, next, return, until and quit 'set_' methods."""

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_step(self):
self.expect_set = [
('line', 2, 'tfunc_main'), ('step', ),
Expand All @@ -601,7 +601,7 @@ def test_step(self):
with TracerRun(self) as tracer:
tracer.runcall(tfunc_main)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_step_next_on_last_statement(self):
for set_type in ('step', 'next'):
with self.subTest(set_type=set_type):
Expand All @@ -616,8 +616,7 @@ def test_step_next_on_last_statement(self):
with TracerRun(self) as tracer:
tracer.runcall(tfunc_main)

@unittest.skip('TODO: RUSTPYTHON')
# AssertionError: All paired tuples have not been processed, the last one was number 1 [('next',), ('quit',)]
@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: All paired tuples have not been processed, the last one was number 1 [('next',), ('quit',)]
def test_stepinstr(self):
self.expect_set = [
('line', 2, 'tfunc_main'), ('stepinstr', ),
Expand All @@ -627,7 +626,7 @@ def test_stepinstr(self):
with TracerRun(self) as tracer:
tracer.runcall(tfunc_main)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_next(self):
self.expect_set = [
('line', 2, 'tfunc_main'), ('step', ),
Expand All @@ -639,7 +638,7 @@ def test_next(self):
with TracerRun(self) as tracer:
tracer.runcall(tfunc_main)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_next_over_import(self):
code = """
def main():
Expand All @@ -654,7 +653,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_next_on_plain_statement(self):
# Check that set_next() is equivalent to set_step() on a plain
# statement.
Expand All @@ -667,7 +666,7 @@ def test_next_on_plain_statement(self):
with TracerRun(self) as tracer:
tracer.runcall(tfunc_main)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_next_in_caller_frame(self):
# Check that set_next() in the caller frame causes the tracer
# to stop next in the caller frame.
Expand All @@ -681,7 +680,7 @@ def test_next_in_caller_frame(self):
with TracerRun(self) as tracer:
tracer.runcall(tfunc_main)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_return(self):
self.expect_set = [
('line', 2, 'tfunc_main'), ('step', ),
Expand All @@ -694,7 +693,7 @@ def test_return(self):
with TracerRun(self) as tracer:
tracer.runcall(tfunc_main)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_return_in_caller_frame(self):
self.expect_set = [
('line', 2, 'tfunc_main'), ('step', ),
Expand All @@ -706,7 +705,7 @@ def test_return_in_caller_frame(self):
with TracerRun(self) as tracer:
tracer.runcall(tfunc_main)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_until(self):
self.expect_set = [
('line', 2, 'tfunc_main'), ('step', ),
Expand All @@ -718,7 +717,7 @@ def test_until(self):
with TracerRun(self) as tracer:
tracer.runcall(tfunc_main)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_until_with_too_large_count(self):
self.expect_set = [
('line', 2, 'tfunc_main'), break_in_func('tfunc_first'),
Expand All @@ -729,7 +728,7 @@ def test_until_with_too_large_count(self):
with TracerRun(self) as tracer:
tracer.runcall(tfunc_main)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_until_in_caller_frame(self):
self.expect_set = [
('line', 2, 'tfunc_main'), ('step', ),
Expand All @@ -741,7 +740,7 @@ def test_until_in_caller_frame(self):
with TracerRun(self) as tracer:
tracer.runcall(tfunc_main)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
@patch_list(sys.meta_path)
def test_skip(self):
# Check that tracing is skipped over the import statement in
Expand Down Expand Up @@ -775,7 +774,7 @@ def test_skip_with_no_name_module(self):
bdb = Bdb(skip=['anything*'])
self.assertIs(bdb.is_skipped_module(None), False)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_down(self):
# Check that set_down() raises BdbError at the newest frame.
self.expect_set = [
Expand All @@ -784,7 +783,7 @@ def test_down(self):
with TracerRun(self) as tracer:
self.assertRaises(BdbError, tracer.runcall, tfunc_main)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_up(self):
self.expect_set = [
('line', 2, 'tfunc_main'), ('step', ),
Expand All @@ -798,15 +797,15 @@ def test_up(self):
class BreakpointTestCase(BaseTestCase):
"""Test the breakpoint set method."""

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_bp_on_non_existent_module(self):
self.expect_set = [
('line', 2, 'tfunc_import'), ('break', ('/non/existent/module.py', 1))
]
with TracerRun(self) as tracer:
self.assertRaises(BdbError, tracer.runcall, tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_bp_after_last_statement(self):
code = """
def main():
Expand All @@ -820,7 +819,7 @@ def main():
with TracerRun(self) as tracer:
self.assertRaises(BdbError, tracer.runcall, tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_temporary_bp(self):
code = """
def func():
Expand All @@ -844,7 +843,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_disabled_temporary_bp(self):
code = """
def func():
Expand Down Expand Up @@ -873,7 +872,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_bp_condition(self):
code = """
def func(a):
Expand All @@ -894,7 +893,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_bp_exception_on_condition_evaluation(self):
code = """
def func(a):
Expand All @@ -914,7 +913,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_bp_ignore_count(self):
code = """
def func():
Expand All @@ -936,7 +935,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_ignore_count_on_disabled_bp(self):
code = """
def func():
Expand Down Expand Up @@ -964,7 +963,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_clear_two_bp_on_same_line(self):
code = """
def func():
Expand All @@ -990,7 +989,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_clear_at_no_bp(self):
self.expect_set = [
('line', 2, 'tfunc_import'), ('clear', (__file__, 1))
Expand Down Expand Up @@ -1044,7 +1043,7 @@ def test_load_bps_from_previous_Bdb_instance(self):
class RunTestCase(BaseTestCase):
"""Test run, runeval and set_trace."""

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_run_step(self):
# Check that the bdb 'run' method stops at the first line event.
code = """
Expand All @@ -1057,7 +1056,7 @@ def test_run_step(self):
with TracerRun(self) as tracer:
tracer.run(compile(textwrap.dedent(code), '<string>', 'exec'))

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_runeval_step(self):
# Test bdb 'runeval'.
code = """
Expand All @@ -1080,7 +1079,7 @@ def main():
class IssuesTestCase(BaseTestCase):
"""Test fixed bdb issues."""

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_step_at_return_with_no_trace_in_caller(self):
# Issue #13183.
# Check that the tracer does step into the caller frame when the
Expand Down Expand Up @@ -1111,7 +1110,7 @@ def func():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_next_until_return_in_generator(self):
# Issue #16596.
# Check that set_next(), set_until() and set_return() do not treat the
Expand Down Expand Up @@ -1153,7 +1152,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_next_command_in_generator_for_loop(self):
# Issue #16596.
code = """
Expand Down Expand Up @@ -1185,7 +1184,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_next_command_in_generator_with_subiterator(self):
# Issue #16596.
code = """
Expand Down Expand Up @@ -1217,7 +1216,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON; Error in atexit._run_exitfuncs')
@unittest.expectedFailure # TODO: RUSTPYTHON; Error in atexit._run_exitfuncs
def test_return_command_in_generator_with_subiterator(self):
# Issue #16596.
code = """
Expand Down Expand Up @@ -1249,8 +1248,7 @@ def main():
with TracerRun(self) as tracer:
tracer.runcall(tfunc_import)

@unittest.skip('TODO: RUSTPYTHON')
# AssertionError: All paired tuples have not been processed, the last one was number 1 [('next',)]
@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: All paired tuples have not been processed, the last one was number 1 [('next',)]
def test_next_to_botframe(self):
# gh-125422
# Check that next command won't go to the bottom frame.
Expand Down
2 changes: 0 additions & 2 deletions Lib/test/test_bytes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2138,7 +2138,6 @@ def test_join(self):
s3 = s1.join([b"abcd"])
self.assertIs(type(s3), self.basetype)

@unittest.skip('TODO: RUSTPYTHON; Fails on ByteArraySubclassWithSlotsTest')
def test_pickle(self):
a = self.type2test(b"abcd")
a.x = 10
Expand All @@ -2153,7 +2152,6 @@ def test_pickle(self):
self.assertEqual(type(a.z), type(b.z))
self.assertFalse(hasattr(b, 'y'))

@unittest.skip('TODO: RUSTPYTHON; Fails on ByteArraySubclassWithSlotsTest')
def test_copy(self):
a = self.type2test(b"abcd")
a.x = 10
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_class.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,6 @@ def assertNotOrderable(self, a, b):
with self.assertRaises(TypeError):
a >= b

@unittest.skip("TODO: RUSTPYTHON; unstable result")
def testHashComparisonOfMethods(self):
# Test comparison and hash of methods
class A:
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ def __getitem__(self, key):
exec('z = a', g, d)
self.assertEqual(d['z'], 12)

@unittest.skip("TODO: RUSTPYTHON; segmentation fault")
def test_extended_arg(self):
# default: 1000 * 2.5 = 2500 repetitions
repeat = int(sys.getrecursionlimit() * 2.5)
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_configparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ def test_read_returns_file_list(self):
parsed_files = cf.read([], encoding="utf-8")
self.assertEqual(parsed_files, [])

@unittest.skip("TODO: RUSTPYTHON, suspected to make CI hang")
# XXX: RUSTPYTHON; This test might cause CI hang
def test_read_returns_file_list_with_bytestring_path(self):
if self.delimiters[0] != '=':
self.skipTest('incompatible format')
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,6 @@ def ctx2_fun():

ctx1.run(ctx1_fun)

@unittest.skip("TODO: RUSTPYTHON; threading is not safe")
@isolated_context
@threading_helper.requires_working_threading()
def test_context_threads_1(self):
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_descr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1834,8 +1834,8 @@ def __init__(self, foo):
object.__init__(A(3))
self.assertRaises(TypeError, object.__init__, A(3), 5)

@unittest.skip('TODO: RUSTPYTHON; This passes, but the `expectedFailure` here is from CPython, so this test is an "UNEXPECTED SUCCESS" (not good)')
@unittest.expectedFailure
# TODO: RUSTPYTHON; The `expectedFailure` here is from CPython, so this test must fail
# @unittest.expectedFailure
def test_restored_object_new(self):
class A(object):
def __new__(cls, *args, **kwargs):
Expand Down
Loading
Loading