Skip to content

remove polluting tests #6733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 1 commit into from
Jan 14, 2026
Merged

remove polluting tests #6733

youknowone merged 1 commit into from
Jan 14, 2026

Conversation

@youknowone
Copy link
Member

@youknowone youknowone commented Jan 14, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated CI/CD pipeline configuration to optimize test environment handling.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This change removes two test entries from environment-polluting test lists in the CI workflow configuration. Specifically, multiprocessing fork server and spawn thread tests are removed from the Linux and macOS test pollution tracking environment variables.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
​.github/workflows/ci.yaml		 Removed test.test_multiprocessing_forkserver.test_threads from Linux environment-polluting tests and test.test_multiprocessing_spawn.test_threads from macOS environment-polluting tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Two threads hop away,
From the pollution list they'd stay,
Linux and macOS now fly free,
The CI pipeline's spree! ✨

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3890f9 and 9c0a9dd.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone marked this pull request as ready for review January 14, 2026 23:36
@youknowone youknowone merged commit b214362 into main Jan 14, 2026
13 of 17 checks passed
@youknowone youknowone deleted the ci branch January 14, 2026 23:36
terryluan12 pushed a commit to terryluan12/RustPython that referenced this pull request Jan 15, 2026
@youknowone @terryluan12
remove polluting tests (RustPython#6733)
bf6340e
@fanninpm
Copy link
Contributor

fanninpm commented Jan 15, 2026

Please also remove the corresponding lines in the test files themselves.

@coderabbitai coderabbitai bot mentioned this pull request Jan 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@youknowone @fanninpm