Multi phase module init #6740
Draft
Multi phase module init #6740
+434
−351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
405fcba to
b830498
Compare
b830498 to
b97576a
Compare
- Use PyModule::__init_dict_from_def() instead of manually creating dict as attribute, fixing module dict initialization - Revert gc.get_referents/get_referrers to NotImplementedError Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
660f2fb to
054b125
Compare
Contributor
|
Code has been automatically formatted The code in this PR has been formatted using:
git pull origin multi-phase-module-init |
7ce8228 to
338374a
Compare
338374a to
5b2598b
Compare
- Restore compile.rs to upstream/main to fix finally block not executing properly in return/break/continue paths. The previous changes to fblock handler clearing were incorrect and caused finally blocks to be skipped. - Remove expectedFailure decorators from test_builtin_functions in test_pickle.py and test_pickletools.py as these tests now pass. - Clean up duplicate test methods in PyPicklerTests class. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
youknowone
commented
Jan 16, 2026
| use crate::vm::{PyRef, VirtualMachine, builtins::PyModule}; | ||
|
|
||
| pub(crate) fn make_module(vm: &VirtualMachine) -> PyRef<PyModule> { | ||
| let _ = vm.import("_hashlib", 0); |
Member
Author
There was a problem hiding this comment.
this line must not be removed
crates/vm/src/macros.rs
Outdated
| @@ -1,5 +1,5 @@ | |||
| #[macro_export] | |||
| macro_rules! extend_module { | |||
| macro_rules! module_exec { | |||
Member
Author
There was a problem hiding this comment.
This is wrong renaming. extend_module is correct here
| use crate::vm::{PyRef, VirtualMachine, builtins::PyModule}; | ||
|
|
||
| pub(crate) fn make_module(vm: &VirtualMachine) -> PyRef<PyModule> { | ||
| let _ = vm.import("_hashlib", 0); |
Member
Author
There was a problem hiding this comment.
this line must not be removed
| #[pymodule(with(cert::ssl_cert, ssl_error::ssl_error, ossl101, ossl111, windows))] | ||
| mod _ssl { | ||
| #[cfg(openssl_vendored)] | ||
| use super::PROBE; |
Member
Author
There was a problem hiding this comment.
does PROBE still need to defined on super?
- Restore extend_module macro name (was incorrectly renamed to module_exec) - Restore sha256/sha512 make_module wrappers that import _hashlib first - Move sha256/sha512 back to single-phase init (get_module_inits) - Add call to add_native_modules for single-phase init modules Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.