Skip to content

Support pickle better with __getnewargs_ex__ #6749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youknowone wants to merge 6 commits into
base: main
Choose a base branch
from
+334 −173
Open

Support pickle better with __getnewargs_ex__ #6749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9efc8d1
Implement pickle more
youknowone Jan 16, 2026
9720798
unmark succesful tests
youknowone Jan 16, 2026
3277a4d
add weakref check
youknowone Jan 16, 2026
1fc57af
check exports in __setstate__
youknowone Jan 16, 2026
4eb7828
remove reducelib
youknowone Jan 16, 2026
a418c68
unmark more tests
youknowone Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Lib/test/test_copy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,6 @@ def __eq__(self, other):
self.assertIsNot(y, x)
self.assertEqual(y.foo, x.foo)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_copy_inst_getnewargs_ex(self):
class C(int):
def __new__(cls, *, foo):
Expand Down Expand Up @@ -507,8 +505,6 @@ def __eq__(self, other):
self.assertEqual(y.foo, x.foo)
self.assertIsNot(y.foo, x.foo)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_deepcopy_inst_getnewargs_ex(self):
class C(int):
def __new__(cls, *, foo):
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,6 @@ def test_copy(self):
dialect = csv.get_dialect(name)
self.assertRaises(TypeError, copy.copy, dialect)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_pickle(self):
for name in csv.list_dialects():
dialect = csv.get_dialect(name)
Expand Down
3 changes: 0 additions & 3 deletions Lib/test/test_descr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5258,7 +5258,6 @@ def _check_reduce(self, proto, obj, args=(), kwargs={}, state=None,
self.assertEqual(obj.__reduce_ex__(proto), reduce_value)
self.assertEqual(obj.__reduce__(), reduce_value)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_reduce(self):
protocols = range(pickle.HIGHEST_PROTOCOL + 1)
args = (-101, "spam")
Expand Down Expand Up @@ -5382,7 +5381,6 @@ class C16(list):
for proto in protocols:
self._check_reduce(proto, obj, listitems=list(obj))

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_special_method_lookup(self):
protocols = range(pickle.HIGHEST_PROTOCOL + 1)
class Picky:
Expand Down Expand Up @@ -5515,7 +5513,6 @@ class E(C):
y = pickle_copier.copy(x)
self._assert_is_copy(x, y)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_reduce_copying(self):
# Tests pickling and copying new-style classes and objects.
global C1
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2130,7 +2130,6 @@ class NEI(NamedInt, Enum):
test_pickle_dump_load(self.assertIs, NEI.y)
test_pickle_dump_load(self.assertIs, NEI)

@unittest.expectedFailure # TODO: RUSTPYTHON; fails on pickle
def test_subclasses_with_getnewargs_ex(self):
class NamedInt(int):
__qualname__ = 'NamedInt' # needed for pickle protocol 4
Expand Down
4 changes: 1 addition & 3 deletions Lib/test/test_lzma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,6 @@ def test_decompressor_bigmem(self, size):

# Pickling raises an exception; there's no way to serialize an lzma_stream.

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_pickle(self):
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.assertRaises(TypeError):
Expand Down Expand Up @@ -2194,4 +2192,4 @@ def test_filter_properties_roundtrip(self):


if __name__ == "__main__":
unittest.main()
unittest.main()
12 changes: 0 additions & 12 deletions Lib/test/test_memoryio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,8 +745,6 @@ def test_init(self):
def test_issue5449(self):
super().test_issue5449()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_pickling(self):
super().test_pickling()

Expand Down Expand Up @@ -777,8 +775,6 @@ def test_truncate(self):
def test_write(self):
super().test_write()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_getstate(self):
memio = self.ioclass()
state = memio.__getstate__()
Expand Down Expand Up @@ -911,8 +907,6 @@ def test_newline_none(self):
def test_newlines_property(self):
super().test_newlines_property()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_pickling(self):
super().test_pickling()

Expand Down Expand Up @@ -954,8 +948,6 @@ def test_widechar(self):
self.assertEqual(memio.tell(), len(buf) * 2)
self.assertEqual(memio.getvalue(), buf + buf)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_getstate(self):
memio = self.ioclass()
state = memio.__getstate__()
Expand Down Expand Up @@ -1006,8 +998,6 @@ def test_newline_cr(self):
def test_newline_crlf(self):
super().test_newline_crlf()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_newline_default(self):
super().test_newline_default()

Expand All @@ -1016,8 +1006,6 @@ def test_newline_default(self):
def test_newline_empty(self):
super().test_newline_empty()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_newline_lf(self):
super().test_newline_lf()

Expand Down
20 changes: 0 additions & 20 deletions Lib/test/test_pickle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ def dumps(self, arg, proto=None, **kwargs):
def test_picklebuffer_error(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_picklebuffer_error()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_bad_getattr(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_bad_getattr()

# TODO: RUSTPYTHON
@unittest.expectedFailure
Expand Down Expand Up @@ -135,15 +131,7 @@ def loads(self, buf, **kwds):
def test_c_methods(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_c_methods()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_complex_newobj_ex(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_complex_newobj_ex()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_py_methods(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_py_methods()

# TODO: RUSTPYTHON
@unittest.expectedFailure
Expand Down Expand Up @@ -239,10 +227,6 @@ def loads(self, buf, **kwds):
def test_c_methods(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_c_methods()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_complex_newobj_ex(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_complex_newobj_ex()

# TODO: RUSTPYTHON
@unittest.expectedFailure
Expand All @@ -259,10 +243,6 @@ def test_correctly_quoted_string(self): # TODO(RUSTPYTHON): Remove this test whe
def test_load_python2_str_as_bytes(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_load_python2_str_as_bytes()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_py_methods(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_py_methods()

# TODO: RUSTPYTHON
@unittest.expectedFailure
Expand Down
8 changes: 0 additions & 8 deletions Lib/test/test_pickletools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,7 @@ def test_oob_buffers(self): # TODO(RUSTPYTHON): Remove this test when it passes
def test_oob_buffers_writable_to_readonly(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_oob_buffers_writable_to_readonly()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_py_methods(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_py_methods()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_complex_newobj_ex(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_complex_newobj_ex()

# TODO: RUSTPYTHON
@unittest.expectedFailure
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10328,7 +10328,6 @@ def test_special_attrs(self):

TypeName = typing.NewType('SpecialAttrsTests.TypeName', Any)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_special_attrs2(self):
# Forward refs provide a different introspection API. __name__ and
# __qualname__ make little sense for forward refs as they can store
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_unittest/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,7 +1297,6 @@ def _makeResult(self):
expected = ['startTestRun', 'stopTestRun']
self.assertEqual(events, expected)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_pickle_unpickle(self):
# Issue #7197: a TextTestRunner should be (un)pickleable. This is
# required by test_multiprocessing under Windows (in verbose mode).
Expand Down
6 changes: 0 additions & 6 deletions Lib/test/test_zlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,15 +747,11 @@ def test_baddecompresscopy(self):
self.assertRaises(ValueError, copy.copy, d)
self.assertRaises(ValueError, copy.deepcopy, d)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_compresspickle(self):
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.assertRaises((TypeError, pickle.PicklingError)):
pickle.dumps(zlib.compressobj(zlib.Z_BEST_COMPRESSION), proto)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_decompresspickle(self):
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.assertRaises((TypeError, pickle.PicklingError)):
Expand Down Expand Up @@ -1006,8 +1002,6 @@ def testDecompress4G(self, size):
compressed = None
decompressed = None

# TODO: RUSTPYTHON
@unittest.expectedFailure
def testPickle(self):
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.assertRaises(TypeError):
Expand Down
86 changes: 0 additions & 86 deletions crates/vm/Lib/python_builtins/__reducelib.py
View file
Open in desktop

This file was deleted.

Loading
Loading