Skip to content

Change dockerfile to be available on aarch64 #6751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 1 commit into from
Jan 17, 2026
Merged

Change dockerfile to be available on aarch64 #6751

youknowone merged 1 commit into from
Jan 17, 2026
+36 −1

Conversation

@youknowone
Copy link
Member

@youknowone youknowone commented Jan 17, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Documentation

    • Added testing guidelines for running tests on Linux containers from macOS, including environment setup and container-based test execution steps.

  • Chores

    • Updated development container base image configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@youknowone youknowone added the skip:ci Skip running the ci label Jan 17, 2026
@youknowone youknowone marked this pull request as ready for review January 17, 2026 10:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Updated the development container base image from a Microsoft-specific Rust container to the official Rust image, and expanded testing documentation with new instructions for cross-OS testing (Linux from macOS using container environments).

Changes

Cohort / File(s) Summary
Container Configuration
.devcontainer/Dockerfile		 Base image updated from mcr.microsoft.com/vscode/devcontainers/rust:1-bullseye to rust:bullseye; clang installation step preserved.
Development Documentation
DEVELOPMENT.md		 Added "Testing on Linux from macOS" subsection with container setup, CLI installation, Rosetta disablement for arm64, image build, and container-based test execution workflow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • ShaharNaveh

Poem

🐰 A lighter Docker base hops in place,
While docs paint testing's cross-platform race,
From macOS to Linux, containers take flight,
Configuration and guidance, both shining so bright! 🚀

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Change dockerfile to be available on aarch64' partially describes the changes but does not capture the main modification, which is changing the base image from a Microsoft-specific container to a standard Rust image. Consider revising the title to more clearly describe the primary change, such as 'Switch Dockerfile base image from VS Code devcontainer to standard Rust image' or 'Update Dockerfile base image and add cross-platform testing documentation'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone merged commit 4eb4949 into RustPython:main Jan 17, 2026
9 checks passed
@youknowone youknowone deleted the dockerfile branch January 17, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip:ci Skip running the ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@youknowone