Skip to content

traverse for generator #6760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 2 commits into from
Jan 18, 2026
Merged

traverse for generator #6760

youknowone merged 2 commits into from
Jan 18, 2026
+78 −8

Conversation

@youknowone
Copy link
Member

@youknowone youknowone commented Jan 17, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Improved garbage collection handling for async generators, coroutines, and generators to enable more efficient memory management.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR adds manual garbage collection traversal support by implementing the Traverse trait for async generators, coroutines, generators, and the core Coro struct, while marking their pyclass definitions with traverse = "manual" to enable explicit GC tracing of contained fields.

Changes

Cohort / File(s) Summary
Async Generator Traversal
crates/vm/src/builtins/asyncgenerator.rs		 Added unsafe impl Traverse for PyAsyncGen, PyAsyncGenWrappedValue, PyAsyncGenASend, PyAsyncGenAThrow, and PyAnextAwaitable; each implementation traverses its inner fields (Coro, finalizer, wrapped values). Updated all five pyclass definitions with traverse = "manual".
Coroutine and Wrapper Traversal
crates/vm/src/builtins/coroutine.rs		 Added unsafe impl Traverse for PyCoroutine (delegates to self.inner) and PyCoroutineWrapper (delegates to self.coro). Updated both pyclass definitions with traverse = "manual".
Generator Traversal
crates/vm/src/builtins/generator.rs		 Added unsafe impl Traverse for PyGenerator delegating to self.inner.traverse(tracer_fn). Updated pyclass definition with traverse = "manual". Added imports for Traverse and TraverseFn.
Core Coro Traversal
crates/vm/src/coroutine.rs		 Added unsafe impl Traverse for Coro struct that traverses frame, name, qualname, and exception fields.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • sys.set_asyncgen_hook #6439 — Modifies the same async generator types (PyAsyncGen, PyAnextAwaitable, PyAsyncGenASend/AThrow/WrappedValue) with lifecycle methods and state management
  • PyAnextAwaitable  #6427 — Introduces or modifies PyAnextAwaitable and async generator types alongside GC traversal additions

Poem

🐰 A rabbit hops through memory lanes,
Tracing coroutines' flowing chains,
Generators yield their GC care,
Traverse marks what's hiding there!
Cleanup bound, no leaks remain ✨

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2026

Code has been automatically formatted

The code in this PR has been formatted using:

  • cargo fmt --all
    Please pull the latest changes before pushing again:
git pull origin traverse

@youknowone youknowone marked this pull request as ready for review January 18, 2026 00:35
@youknowone youknowone merged commit abea6bd into RustPython:main Jan 18, 2026
11 of 13 checks passed
@youknowone youknowone deleted the traverse branch January 18, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@youknowone