Skip to content

auto mark parent tests #6778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 2 commits into from
Jan 18, 2026
Merged

auto mark parent tests #6778

youknowone merged 2 commits into from
Jan 18, 2026
+79 −5

Conversation

@youknowone
Copy link
Member

@youknowone youknowone commented Jan 18, 2026 •
edited by coderabbitai bot
Loading

also fix #6721

Summary by CodeRabbit

  • Chores
    • Auto-format workflow now runs unconditionally on all PRs, regardless of label configuration
    • Enhanced test marking script with inheritance-aware method detection for improved accuracy in identifying test methods
    • Optimized library updater performance through pre-populated caching strategy

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request modifies CI/CD automation and test infrastructure across three files: removing a label-based conditional guard from the auto-format workflow, enhancing test failure detection with AST-based inheritance analysis, and optimizing cache initialization in patch line processing.

Changes

Cohort / File(s) Summary
CI/CD Workflow
.github/workflows/pr-auto-commit.yaml		 Removed conditional guard preventing auto_format job execution when PR has skip:ci label; job now runs unconditionally
Test Automation
scripts/auto_mark_test.py		 Enhanced test pattern detection from "Run tests? sequentially" to "Run <n> tests? sequentially"; added build_inheritance_info() and find_method_definition() helpers for AST-based inheritance analysis; modified remove_expected_failures() to resolve method definitions across class inheritance hierarchies
Patch Processing
scripts/lib_updater.py		 Refactored cache initialization in iter_patch_lines() to pre-populate class end lines before Phase 1 processing, removing incremental cache updates during iteration

Possibly related PRs

  • RustPython/RustPython#6706: Modifies the same .github/workflows/pr-auto-commit.yaml workflow for formatting/commit step execution control

Poem

🐰 The workflows now run without delay,
While tests trace inheritance their way,
With caches built before the race,
Each change finds its rightful place! ✨

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone added the skip:ci Skip running the ci label Jan 18, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2026

Code has been automatically formatted

The code in this PR has been formatted using:

  • ruff format
    Please pull the latest changes before pushing again:
git pull origin auto-mark-parent

@youknowone youknowone marked this pull request as ready for review January 18, 2026 13:06
@youknowone youknowone merged commit 2b8fac3 into RustPython:main Jan 18, 2026
8 of 9 checks passed
@youknowone youknowone deleted the auto-mark-parent branch January 18, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip:ci Skip running the ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

auto-format must not be blocked by skip:ci label

1 participant

@youknowone