Skip to content

Conversation

@moreal
Copy link
Contributor

@moreal moreal commented Jan 18, 2026

Overview

What was previously Lib/_compression.py is now Lib/compression/_common/_streams.py, and the original file has been removed. During this update process, test files also needed updating, and related compression module files were changed as of version 3.14.2.

As a note: The test_zstd file has been newly added, but since _zstd is not yet supported, it is automatically skipped so the test will not fail.

Context

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (17)
  • Lib/bz2.py is excluded by !Lib/**
  • Lib/compression/__init__.py is excluded by !Lib/**
  • Lib/compression/_common/__init__.py is excluded by !Lib/**
  • Lib/compression/_common/_streams.py is excluded by !Lib/**
  • Lib/compression/bz2.py is excluded by !Lib/**
  • Lib/compression/gzip.py is excluded by !Lib/**
  • Lib/compression/lzma.py is excluded by !Lib/**
  • Lib/compression/zlib.py is excluded by !Lib/**
  • Lib/compression/zstd/__init__.py is excluded by !Lib/**
  • Lib/compression/zstd/_zstdfile.py is excluded by !Lib/**
  • Lib/gzip.py is excluded by !Lib/**
  • Lib/lzma.py is excluded by !Lib/**
  • Lib/test/test_bz2.py is excluded by !Lib/**
  • Lib/test/test_gzip.py is excluded by !Lib/**
  • Lib/test/test_lzma.py is excluded by !Lib/**
  • Lib/test/test_zlib.py is excluded by !Lib/**
  • Lib/test/test_zstd.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone
Copy link
Member

Are you also interested in xz and zstd support?

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@youknowone youknowone merged commit 9b5eefb into RustPython:main Jan 18, 2026
13 checks passed
@moreal moreal mentioned this pull request Jan 18, 2026
@moreal
Copy link
Contributor Author

moreal commented Jan 18, 2026

Are you also interested in xz and zstd support?

@youknowone I'm not very familiar with compression algorithms, so if I get the chance to study them, I'd be really happy. However, due to other personal things to do, I won't be able to look into this issue for at least three days. So if the issue is still open in a few days, I'll take a look at it one by one.

I've also created a zstd issue! #6793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants