Run benchmarks with stdlib native modules #6792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 WalkthroughWalkthroughAdds Changes
Sequence Diagram(s)sequenceDiagram
participant Bench as Bench Harness
participant Init as Interpreter::with_init
participant VM as VM (pre-enter block)
participant Stdlib as rustpython_stdlib
Bench->>Init: construct Interpreter::with_init(...)
Init->>VM: enter pre-init closure
VM->>Stdlib: rustpython_stdlib::get_module_inits()
VM->>Stdlib: vm.add_native_modules(module_inits)
VM-->>Bench: VM ready with native stdlib modules
Bench->>VM: run benchmark code (imports/use stdlib)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Code has been automatically formatted The code in this PR has been formatted using:
git pull origin benchmark-with-stdlib |
4550ea9 to
e0c812d
Compare
Change benchmark interpreter from without_stdlib to with_init to load Rust-optimized native modules like _json, ensuring benchmarks measure actual optimized performance rather than pure Python fallbacks. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
e0c812d to
c3180e3
Compare
youknowone
approved these changes
Jan 18, 2026
Member
youknowone
left a comment
There was a problem hiding this comment.
Probably that was written for vm performance at the first time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personally, I was checking https://rustpython.github.io/benchmarks to see if benchmarks improved after the
json.loadsenhancement, but there was actually no performance improvement. Upon reviewing this again, I suspect it was running with a Pure Python implementation using an interpreter without stdlib. So if there are no particular issues, how about running the benchmark with a version that includes stdlib?I'm not very familiar with whether the presence of a standard library has a significant impact on performance benchmarks, so I would be really happy if you could share your opinion!
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.