Remake update_lib #6796
Draft
Remake update_lib #6796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Code has been automatically formatted The code in this PR has been formatted using:
git pull origin lib_updater |
youknowone
commented
Jan 19, 2026
Comment on lines
+10
to
+20
| If during the upgrade process you encounter any of the following issues with `scripts/update_lib`: | ||
| - A feature that should be automated but isn't supported | ||
| - A bug or unexpected behavior in the tool | ||
| - Missing functionality that would make the upgrade easier | ||
|
|
||
| **STOP the upgrade and report the issue first.** Describe: | ||
| 1. What you were trying to do | ||
| - Library name | ||
| - The full command executed (e.g. python scripts/update_lib quick cpython/Lib/$ARGUMENTS.py) | ||
| 2. What went wrong or what's missing | ||
| 3. Expected vs actual behavior |
Member
Author
There was a problem hiding this comment.
Rather than making machine work for workaround, putting the effort to enhance tooling can be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @moreal
I am going to rewrite this tools more organized library update toolkit, and remain rooms for further automation.
scripts/update_libwill be main entrance.lib_updater
->
scripts/update_lib patches(--from --to)->
scripts/update_lib migrate(--quick-upgrade)auto_mark_test
->
scripts/update_lib auto_markAlso
scripts/update_lib quickis added to upgrade a whole package at once, copy the library, remove unexected sucesss new add expectedFailure for newly added failing tests but not about regression.The format also will be aligned to ruff format and PEP8 to fix #6701.
Keeping draft to test for a few more libraries. Please feedback.