Introduce /upgrade-pylib-next
#6827
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
.claude/commands/upgrade-pylib.md
Outdated
| - **Test assertion failure** → `@unittest.expectedFailure` with `# TODO: RUSTPYTHON` comment | ||
| - **Panic/crash** → `@unittest.skip("TODO: RUSTPYTHON; <panic message>")` | ||
| - **Class-specific markers**: If a test fails only in the C implementation (TestCFoo) but passes in the Python implementation (TestPyFoo), or vice versa, add the marker to the specific subclass, not the base class: | ||
| 3. **Mark remaining test failures with auto-mark** |
There was a problem hiding this comment.
quick now auto-mark newly added failing tests. only regressions are remained failing.
Before step 3, let's add review the failing tests and analyze If that's justified to mark failure or not.
Lots of them will be better to report issue or worth to try fix them; otherwise upgrade the dependency lib first.
There was a problem hiding this comment.
I'm dogfooding this command, and as your suggestion, it fixes a failed test automatically!
(Other tests (snippets) seem to fail but anyway 😅)
There was a problem hiding this comment.
Great, it is good as long as it doesn't blindly mark everything expectedFailure
cb9edb5 to
eb416e9
Compare
085328e to
273678f
Compare
273678f to
fc57173
Compare
This pull request introduces
/upgrade-pylib-nextcommand to find a module to update by runningscripts/update_lib todo(#6823). It just finds a module to update and delegates other to/upgrade-pylib. (cc #6580)This pull request also has changes about
/upgrade-pylib. It became to useauto-marksubcommand to test newly introduced tests also.