fix: regularizer serialization problem#1250
Merged
SanftMonster merged 2 commits intoSciSharp:masterfrom May 21, 2024
SchoenTannenbaum:master
Merged
fix: regularizer serialization problem#1250SanftMonster merged 2 commits intoSciSharp:masterfrom SchoenTannenbaum:master
SanftMonster merged 2 commits intoSciSharp:masterfrom
SchoenTannenbaum:master
Conversation
Contributor
Author
|
@AsakusaRinne This is the completed change with regularizer read and write unit tests done completely in ModelLoadTest.cs |
SanftMonster
approved these changes
May 21, 2024
Collaborator
SanftMonster
left a comment
There was a problem hiding this comment.
Looks great! Thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo redo for pull request: #1247