This repository was archived by the owner on Jun 1, 2023. It is now read-only.
[BETA] Enable Theme Kit Access passwords#2664
Merged
gonzaloriestra merged 1 commit intomainfrom Oct 19, 2022
Merged
Conversation
b6d8d19 to
079d64e
Compare
079d64e to
a5821af
Compare
alvaro-shopify
approved these changes
Oct 19, 2022
Contributor
alvaro-shopify
left a comment
There was a problem hiding this comment.
Tophated and works like a charm!. Code LGTM
|
Hey guys, can someone please explain how this works, it sounds super useful. Is this a way to store credentials for each store and not have to manually log in / out between stores? @gonzaloriestra @alvaro-shopify |
Contributor
Author
|
@lesterdefreitas you can now use CLI 3.x for theme development. And you can easily switch the store by passing More info: |
|
@gonzaloriestra oh awesome, thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
First step for https://github.com/Shopify/shopify-cli-planning/issues/332
Fixes https://github.com/Shopify/shopify-cli-planning/issues/365
A very similar PR was merged and then reverted, as we wanted to finish other related work first.
WHAT is this pull request doing?
SHOPIFY_CLI_ADMIN_AUTH_TOKENcontains a Theme Kit Access password, the theme requests will go through Theme Kit Access API instead of Admin API, so the password is validated. As the login is not required, it also requires passing the store URL throughSHOPIFY_SHOP.SHOPIFY_CLI_STOREtoSHOPIFY_SHOP, which was already existing. It was added recently to be used from the CLI3. I'll update the CLI3 as well to useSHOPIFY_SHOP.How to test your changes?
Check that theme commands work the same way when logged in (by using the Admin API):
bin/shopify loginDEBUG=1 bin/shopify theme listCheck that they also work with a Theme Kit Access password (by using Theme Access Kit API):
bin/shopify logoutDEBUG=1 SHOPIFY_SHOP=your-shop.myshopify.com SHOPIFY_CLI_ADMIN_AUTH_TOKEN=your-password bin/shopify theme listUpdate checklist