This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Enable Theme Access passwords for theme serve#2681
Merged
gonzaloriestra merged 4 commits intomainfrom Dec 19, 2022
Merged
Conversation
mgmanzella
reviewed
Nov 9, 2022
Contributor
mgmanzella
left a comment
There was a problem hiding this comment.
nice! 🔥 left one question
pepicrft
approved these changes
Nov 10, 2022
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to https://github.com/Shopify/shopify-cli-planning/issues/376
WHAT is this pull request doing?
Proxies Storefront Renderer requests from the dev server through Theme Access API when a password is provided
How to test your changes?
Once https://github.com/Shopify/theme-access/pull/2463 and https://github.com/Shopify/storefront-renderer/pull/15845 are released, it can be tested with:
SHOPIFY_SHOP=your-shop SHOPIFY_CLI_ADMIN_AUTH_TOKEN=password SHOPIFY_CLI_STOREFRONT_RENDERER_AUTH_TOKEN=password shopify theme serveOtherwise, it requires updating the Theme Access URL to local/staging and hard-coding an access token for SFR here.
Update checklist