Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Add sunset warnings#2694

Merged
gonzaloriestra merged 4 commits intomainfrom
sunset-warning
Nov 29, 2022
Merged

Add sunset warnings#2694
gonzaloriestra merged 4 commits intomainfrom
sunset-warning

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Nov 25, 2022

WHY are these changes introduced?

Fixes https://github.com/Shopify/shopify-cli-planning/issues/453

The CLI 2.x will be sunset on April 28, 2023, so we want to warn about that on each command.

WHAT is this pull request doing?

  • Adds a warning on each command, including extra information for app, theme, and app/extension creation commands
  • Adds a post installation message for Homebrew

25-30-vicee-ynllt

How to test your changes?

Just run any command

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrementing this when releasing).
  • I've included any post-release steps in the section above (if needed).

@gonzaloriestra gonzaloriestra marked this pull request as ready for review November 25, 2022 11:49
@gonzaloriestra gonzaloriestra requested review from a team, Arkham and alvaro-shopify and removed request for a team November 25, 2022 11:49
@gonzaloriestra gonzaloriestra merged commit ba6662e into main Nov 29, 2022
@gonzaloriestra gonzaloriestra deleted the sunset-warning branch November 29, 2022 12:16
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems December 5, 2022 15:28 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants