This repository was archived by the owner on Jun 1, 2023. It is now read-only.
The CLI should not report IO messages when the --json flag is passed#2731
Merged
The CLI should not report IO messages when the --json flag is passed#2731
--json flag is passed#2731Conversation
charlespwd
approved these changes
Feb 17, 2023
Poitrin
approved these changes
Feb 17, 2023
charlespwd
reviewed
Feb 17, 2023
|
|
||
| def report(message) | ||
| ctx.puts(message) if @enabled | ||
| ctx.error(message) if @enabled |
Contributor
There was a problem hiding this comment.
Should we also change the doc? Doc says standard output. Do we want log and report to be separate methods?
Contributor
Author
There was a problem hiding this comment.
Good catch! 🚀 I've updated the doc. Also, regarding the report method, reporters (we have more than one) are utility classes used by the Syncer, so it can control when status messages are reported and when they are ignored (with that in mind, I personally would keep the report method).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Backport Shopify/cli#1379
Update checklist