Conversation
Contributor
|
Looks good to me overall! yeah I wonder why it wasnt updated before - thanks for the PR. |
TamimiGitHub
approved these changes
Jan 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should have been done a long time ago. Factory profile 10_5 changed how raw binary payloads were encoded when using a BytesMessage... moving from a latin-1 encoded String to a UInt8Array. These updates should make it easier for users of our JS API to use current best practices and help reduce confusion.
Additionally, included some helpful "if/else" blocks in various consumer or subscriber apps for checking if a TextMessage (SDT) was received, or a BytesMessage, and handling it properly. And also on the publisher side, including example lines for publishing either a raw BytesMessage or an SDT TextMessage.