Support for user auth(). #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syncano/models/accounts.py
Outdated
|
|
||
| data = { | ||
| 'username': connection.username, | ||
| 'password' : connection.password |
Member
|
some test would be nice ;) |
Member
Author
|
Now it can be used that way, we have to rethink how to do it in case we want to do it during the connection. connection = syncano.connect(api_key='key', instance_name='picoblocks')
print connection.User().auth(username='maciej@kucharz.net', password='test123') |
syncano/models/accounts.py
Outdated
| connection = self._get_connection() | ||
|
|
||
| if not (username and password): | ||
| raise SyncanoValueError('You need provide username and password!') |
Contributor
There was a problem hiding this comment.
We usually use dots et the end of Exception msg.
Contributor
|
@mkucharz what about simple test case? I think that you can add it in integration_test_accounts:) |
Contributor
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it is right place...