Skip to content

fix: DateToDay #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raklaptudirm merged 9 commits into from
Oct 10, 2022
Merged

fix: DateToDay #1125

raklaptudirm merged 9 commits into from
Oct 10, 2022

Conversation

@chetanppatil
Copy link
Contributor

@chetanppatil chetanppatil commented Oct 5, 2022 •
edited by appgurueu
Loading

Open in Gitpod know more

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@chetanppatil
fixes: #1121 fix date-to-day conversion issue
4c3f6c0 
- updated functionality to use Zeller's congruence to find day
- updated test cases
@chetanppatil chetanppatil changed the title :fix: DayToDay giving wrong day 🐛 DayToDay giving wrong day Oct 5, 2022
@chetanppatil chetanppatil changed the title 🐛 DayToDay giving wrong day 🐛 DateToDay giving wrong day Oct 5, 2022
@chetanppatil
Copy link
Contributor Author

chetanppatil commented Oct 6, 2022

@appgurueu Could you please share what are your thoughts on this PR?
It will be really helpful for me if there are any improvements I can take care of next time.
Thanks

@chrisgalvan chrisgalvan mentioned this pull request Oct 6, 2022
Closed
11 tasks
appgurueu
appgurueu reviewed Oct 7, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 7, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 7, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 7, 2022
View reviewed changes
@appgurueu appgurueu linked an issue Oct 7, 2022 that may be closed by this pull request
DateToDay.js giving wrong day #1121
Closed
@chetanppatil
Feedback implementation
eea609a 
- updated comments
- removed monthList completely
- converted daysName List to an array
@chetanppatil chetanppatil requested a review from appgurueu October 7, 2022 09:49
appgurueu
appgurueu reviewed Oct 7, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 7, 2022
View reviewed changes
@chetanppatil chetanppatil requested a review from appgurueu October 7, 2022 13:28
@appgurueu appgurueu changed the title 🐛 DateToDay giving wrong day Fix DateToDay Oct 8, 2022
@appgurueu appgurueu mentioned this pull request Oct 8, 2022
Closed
9 tasks
@appgurueu appgurueu added the fix Fixes a bug label Oct 8, 2022
appgurueu
appgurueu reviewed Oct 9, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 9, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 9, 2022
View reviewed changes
@chetanppatil chetanppatil requested a review from appgurueu October 9, 2022 18:54
@raklaptudirm raklaptudirm changed the title Fix DateToDay fix: DateToDay Oct 10, 2022
@raklaptudirm raklaptudirm merged commit d94929e into TheAlgorithms:master Oct 10, 2022
@chetanppatil
Copy link
Contributor Author

chetanppatil commented Oct 10, 2022

Thank you @appgurueu @raklaptudirm for merging my PR.

Thank you @appgurueu for all your valuable review comments and suggestion, I really learned a lot from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

fix Fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DateToDay.js giving wrong day

3 participants

@chetanppatil @appgurueu @raklaptudirm