Skip to content

chore: check for invalid input to factorial#1229

Merged
appgurueu merged 9 commits intoTheAlgorithms:masterfrom
abdullyahuza:master
Oct 27, 2022
Merged

chore: check for invalid input to factorial#1229
appgurueu merged 9 commits intoTheAlgorithms:masterfrom
abdullyahuza:master

Conversation

@abdullyahuza
Copy link
Contributor

@abdullyahuza abdullyahuza commented Oct 26, 2022 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

raklaptudirm
raklaptudirm requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a check for negative numbers while you are at it?

appgurueu
appgurueu reviewed Oct 27, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 27, 2022
View reviewed changes
appgurueu
appgurueu previously approved these changes Oct 27, 2022
View reviewed changes
@abdullyahuza
Copy link
Contributor Author

abdullyahuza commented Oct 27, 2022

All done.

raklaptudirm
raklaptudirm reviewed Oct 27, 2022
View reviewed changes
@raklaptudirm
Copy link
Member

raklaptudirm commented Oct 27, 2022

You don't seem to have removed the typeof check, so do that.

@raklaptudirm raklaptudirm changed the title Add Invalid input to Factorial chore: check for invalid input to factorial Oct 27, 2022
@appgurueu appgurueu merged commit 5364a1c into TheAlgorithms:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abdullyahuza @raklaptudirm @appgurueu