fix: throw error and add tests for ReverseNumber#1608
Merged
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom Feb 19, 2024
Merged
fix: throw error and add tests for ReverseNumber#1608raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
ReverseNumber#1608raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
+ Coverage 83.47% 83.62% +0.14%
==========================================
Files 377 377
Lines 19745 19745
Branches 2907 2912 +5
==========================================
+ Hits 16482 16511 +29
+ Misses 3263 3234 -29 ☔ View full report in Codecov by Sentry. |
appgurueu
approved these changes
Feb 15, 2024
raklaptudirm
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Errors should be thrown not returned. This PR also adds tests. I do not want to specify how the
ReverseNumbershould react to negative inputs, so I did not tests covering such situation.Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.