Skip to content

fix: handle zeros in CoPrimeCheck#1622

Merged
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
vil02:zeros_in_CoPrimeCheck
Feb 29, 2024
Merged

fix: handle zeros in CoPrimeCheck#1622
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
vil02:zeros_in_CoPrimeCheck

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented Feb 28, 2024

Open in Gitpod know more

Describe your change:

Zeros are not properly handled in CoPrimeCheck. This PR fixes that and simplifies the implementation. It is a continuation of #1609 and #1621.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@vil02 vil02 marked this pull request as ready for review February 28, 2024 16:33
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.63%. Comparing base (c067a34) to head (1f88b1c).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
- Coverage   83.64%   83.63%   -0.01%     
==========================================
  Files         377      377              
  Lines       19744    19733      -11     
  Branches     2914     2907       -7     
==========================================
- Hits        16514    16503      -11     
  Misses       3230     3230

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raklaptudirm raklaptudirm merged commit 8734dfc into TheAlgorithms:master Feb 29, 2024
@vil02 vil02 deleted the zeros_in_CoPrimeCheck branch February 29, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vil02 @codecov-commenter @appgurueu @raklaptudirm