Skip to content

Upgraded hexToBinary function #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 6 commits into from
Mar 2, 2022
Merged

Upgraded hexToBinary function #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2354ba8
feat: used js object intead of switch
fahimfaisaal Mar 1, 2022
f4ba14a
pref: optimzed the algo with regex & replace method
fahimfaisaal Mar 1, 2022
3fc90f7
feat: add hex validation with test case
fahimfaisaal Mar 1, 2022
6d9e10a
feat: add type validation
fahimfaisaal Mar 1, 2022
d96a70b
chore: fix grammar mistake
fahimfaisaal Mar 1, 2022
fa985c0
docs: add binLookup comments
fahimfaisaal Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 31 additions & 24 deletions Conversions/HexToBinary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,41 @@
const binLookup = (c) => {
switch (c.toLowerCase()) {
case '0': return '0000'
case '1': return '0001'
case '2': return '0010'
case '3': return '0011'
case '4': return '0100'
case '5': return '0101'
case '6': return '0110'
case '7': return '0111'
case '8': return '1000'
case '9': return '1001'
case 'a': return '1010'
case 'b': return '1011'
case 'c': return '1100'
case 'd': return '1101'
case 'e': return '1110'
case 'f': return '1111'
default: return ''
}
}
const binLookup = (key) => ({
0: '0000',
1: '0001',
2: '0010',
3: '0011',
4: '0100',
5: '0101',
6: '0110',
7: '0111',
8: '1000',
9: '1001',
a: '1010',
b: '1011',
c: '1100',
d: '1101',
e: '1110',
f: '1111'
}[key.toLowerCase()]) // select the binary number by valid hex key with the help javascript object

const hexToBinary = (hexString) => {
if (typeof hexString !== 'string') {
throw new TypeError('Argument is not a string type')
}

if (/[^\da-f]/gi.test(hexString)) {
throw new Error('Argument is not a valid HEX code!')
}
/*
Function for converting Hex to Binary

1. We convert every hexadecimal bit to 4 binary bits
2. Conversion goes by searching in the lookup table
*/

*/
const hexLexemes = hexString.split('')
return hexLexemes.map(lexeme => binLookup(lexeme)).join('')
return hexString.replace(
/[0-9a-f]/gi,
lexeme => binLookup(lexeme)
)
}

export default hexToBinary
14 changes: 13 additions & 1 deletion Conversions/test/HexToBinary.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
import hexToBinary from '../HexToBinary'

describe('hexToBinary', () => {
describe('Testing hexToBinary', () => {
it('expects throw error in invalid types', () => {
expect(() => hexToBinary(false)).toThrowError()
expect(() => hexToBinary(null)).toThrowError()
expect(() => hexToBinary(23464)).toThrowError()
})

it('expects throw error in invalid hex', () => {
expect(() => hexToBinary('Hello i am not a valid Hex')).toThrowError()
expect(() => hexToBinary('Gf46f')).toThrowError()
expect(() => hexToBinary('M')).toThrowError()
})

it('expects to return correct hexadecimal value', () => {
expect(hexToBinary('8')).toBe('1000')
})
Expand Down