Skip to content

Add test case to RGBToHex & RailwayTimeConversion algorithm#935

Merged
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
Ankush263:branch1
Mar 19, 2022
Merged

Add test case to RGBToHex & RailwayTimeConversion algorithm#935
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
Ankush263:branch1

Conversation

@Ankush263
Copy link
Contributor

Welcome to the JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • [ ✅] Add test case?

Checklist:

  • [✅ ] I have read CONTRIBUTING.md.
  • [✅ ] This pull request is all my own work -- I have not plagiarized.
  • [✅ ] I know that pull requests will not be merged if they fail the automated tests.
  • [✅ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [✅ ] All new JavaScript files are placed inside an existing directory.
  • [ ✅] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [✅ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ ✅] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Ankush263 Ankush263 requested a review from raklaptudirm as a code owner March 19, 2022 11:14
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put separate changes in separate pull requests.

@raklaptudirm raklaptudirm added feature Adds a new feature Reviewed labels Mar 19, 2022
@raklaptudirm raklaptudirm merged commit bb23382 into TheAlgorithms:master Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants