Skip to content

Add basic check for customName in property access transform #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 1 commit into from
Feb 7, 2024
Merged

Add basic check for customName in property access transform #1534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/transformation/visitors/access.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
captureThisValue,
} from "./optional-chaining";
import { SyntaxKind } from "typescript";
import { getCustomNameFromSymbol } from "./identifier";

function addOneToArrayAccessArgument(
context: TransformationContext,
Expand Down Expand Up @@ -108,10 +109,16 @@ export function transformPropertyAccessExpressionWithCapture(
node: ts.PropertyAccessExpression,
thisValueCapture: lua.Identifier | undefined
): ExpressionWithThisValue {
const property = node.name.text;
const type = context.checker.getTypeAtLocation(node.expression);
const isOptionalLeft = isOptionalContinuation(node.expression);

let property = node.name.text;
const symbol = context.checker.getSymbolAtLocation(node.name);
const customName = getCustomNameFromSymbol(symbol);
if (customName) {
property = customName;
}

const constEnumValue = tryGetConstEnumValue(context, node);
if (constEnumValue) {
return { expression: constEnumValue };
Expand Down
2 changes: 2 additions & 0 deletions test/translation/__snapshots__/transformation.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ escapedCharsInTemplateString = "\\\\ \\0 \\b \\t \\n \\v \\f \\" ' \`"
nonEmptyTemplateString = ("Level 0: \\n\\t " .. ("Level 1: \\n\\t\\t " .. ("Level 3: \\n\\t\\t\\t " .. "Last level \\n --") .. " \\n --") .. " \\n --") .. " \\n --""
`;

exports[`Transformation (customNameWithNoSelf) 1`] = `"TestNamespace.pass()"`;

exports[`Transformation (exportStatement) 1`] = `
"local ____exports = {}
local xyz = 4
Expand Down
7 changes: 7 additions & 0 deletions test/translation/transformation/customNameWithNoSelf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
/** @noSelf */
declare namespace TestNamespace {
/** @customName pass */
function fail(): void;
}

TestNamespace.fail();