Skip to content

Fix crash when using lualib_bundle in an environment without coroutines #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 3 commits into from
Mar 21, 2024
Merged

Fix crash when using lualib_bundle in an environment without coroutines #1547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03b49ec
Don't crash if coroutine not supported
GlassBricks Mar 17, 2024
b8f9b34
Add test for environment without coroutine
GlassBricks Mar 17, 2024
1bcb478
Fix prettier
GlassBricks Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lualib/Await.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import { __TS__Promise } from "./Promise";

const coroutine = _G.coroutine ?? {};
const cocreate = coroutine.create;
const coresume = coroutine.resume;
const costatus = coroutine.status;
Expand Down
11 changes: 11 additions & 0 deletions test/unit/builtins/loading.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,17 @@ test("lualib should not include tstl header", () => {
);
});

test("using lualib does not crash when coroutine is not defined", () => {
util.testModule`
declare const _G: any;
declare function require(this: void, name: string): any

_G.coroutine = undefined;
require("lualib_bundle");
export const result = 1
`.expectToEqual({ result: 1 });
});

describe("Unknown builtin property", () => {
test("access", () => {
util.testExpression`Math.unknownProperty`
Expand Down