Skip to content

Fix bug with using dispose when using disposable class #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 1 commit into from
Sep 21, 2024
Merged

Fix bug with using dispose when using disposable class #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lualib/Using.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export function __TS__Using<TArgs extends Disposable[], TReturn>(
this: undefined,
cb: (...args: TArgs) => TReturn,
cb: (this: void, ...args: TArgs) => TReturn,
...args: TArgs
): TReturn {
let thrownError;
Expand Down
24 changes: 24 additions & 0 deletions test/unit/using.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,3 +193,27 @@ test("await using no extra diagnostics (#1571)", () => {
}
`.expectToHaveNoDiagnostics();
});

// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1584
test("works with disposable classes (#1584)", () => {
util.testFunction`
const log = [];

class Scoped {
action(): void {
log.push("action")
}
[Symbol.dispose]() {
log.push("cleanup")
}
}

function TestScoped(): void {
using s = new Scoped();
s.action();
}

TestScoped();
return log;
`.expectToEqual(["action", "cleanup"]);
});