#1677 fix enum nested in namespace#1679
Closed
felixhirt wants to merge 6 commits intoTypeScriptToLua:masterfrom
Closed
#1677 fix enum nested in namespace#1679felixhirt wants to merge 6 commits intoTypeScriptToLua:masterfrom
felixhirt wants to merge 6 commits intoTypeScriptToLua:masterfrom
Conversation
…tomize extension name and version
…eparate lines (for debugging)
…r code accepts breakpoints
Perryvw
requested changes
Feb 16, 2026
Member
Perryvw
left a comment
There was a problem hiding this comment.
There seem to be way more changes in this branch than just the fix I expected. Please clean this up
| D | ||
| } | ||
| } | ||
| `.tap(builder => { |
Member
There was a problem hiding this comment.
You can just use expectToMatchSnapshot() instead if you want to check the entire content
Contributor
Author
|
oh damn yes i should have created a branch, i almost immediately had to continue customization, sorry for this, i will create a new pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1677
Not sure how to do the test correctly, maybe you can improve that or tell me how to