Skip to content

Fix enum nested in namespace #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 2 commits into from
Feb 23, 2026
Merged

Fix enum nested in namespace #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba317ff
fix enum nested in namespace
felixhirt Jan 26, 2026
246e76c
use snapshot to test
felixhirt Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/transformation/visitors/enum.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as ts from "typescript";
import * as lua from "../../LuaAST";
import { FunctionVisitor, TransformationContext } from "../context";
import { AnnotationKind, getTypeAnnotations } from "../utils/annotations";
import { getSymbolExportScope } from "../utils/export";
import { addExportToIdentifier, getSymbolExportScope } from "../utils/export";
import { createLocalOrExportedOrGlobalDeclaration } from "../utils/lua-ast";
import { isFirstDeclaration } from "../utils/typescript";
import { transformIdentifier } from "./identifier";
Expand Down Expand Up @@ -32,7 +32,7 @@ export const transformEnumDeclaration: FunctionVisitor<ts.EnumDeclaration> = (no
if (!membersOnly && isFirstDeclaration(context, node)) {
const name = transformIdentifier(context, node.name);
const table = lua.createBinaryExpression(
lua.cloneIdentifier(name),
addExportToIdentifier(context, name),
lua.createTableExpression(),
lua.SyntaxKind.OrOperator
);
Expand Down
12 changes: 12 additions & 0 deletions test/unit/__snapshots__/enum.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`enum nested in namespace 1`] = `
"A = A or ({})
do
A.TestEnum = A.TestEnum or ({})
A.TestEnum.B = 0
A.TestEnum[A.TestEnum.B] = "B"
A.TestEnum.C = 1
A.TestEnum[A.TestEnum.C] = "C"
end"
`;
11 changes: 11 additions & 0 deletions test/unit/enum.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,3 +203,14 @@ test("enum merging multiple files", () => {
)
.expectToMatchJsResult();
});

test("enum nested in namespace", () => {
util.testModule`
namespace A {
export enum TestEnum {
B,
C
}
}
`.expectLuaToMatchSnapshot();
});
Loading