Rewrite some sections of the website to make it more comprehensive#144
Merged
Perryvw merged 43 commits intoTypeScriptToLua:sourcefrom Mar 6, 2023
Zamiell:patch-1
Merged
Rewrite some sections of the website to make it more comprehensive#144Perryvw merged 43 commits intoTypeScriptToLua:sourcefrom Zamiell:patch-1
Perryvw merged 43 commits intoTypeScriptToLua:sourcefrom
Zamiell:patch-1
Conversation
Perryvw
reviewed
Feb 23, 2023
Co-authored-by: Perry van Wesel <Perryvw@users.noreply.github.com>
Perryvw
reviewed
Feb 24, 2023
Member
Perryvw
left a comment
There was a problem hiding this comment.
I really wish you had split these edits up over multiple MRs, one per file, and had not changed half the website in a MR called 'update external-code.md'
Contributor
Author
|
i think i fixed all the issues now |
Perryvw
reviewed
Feb 26, 2023
Perryvw
requested changes
Feb 28, 2023
Member
Perryvw
left a comment
There was a problem hiding this comment.
I don't know why I have to ask this again, but please DO NOT rename docs files, it will break external links pointing to our documentaiton.
Co-authored-by: Perry van Wesel <Perryvw@users.noreply.github.com>
Contributor
Author
|
i figured it was unlikely for there to be external links to these pages specifically, and it makes the new organization look less bugged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.