Ian M. Davis Homework#15
Merged
PythonCHB merged 6 commits intoUWPCE-PythonCert:masterfrom Oct 13, 2014
Merged
Conversation
…ession02 directory of my student directory
… 20th term correctly. Contains a useful docstring and some assertions for some basic testing.
…erm of the lucas function. Checked that it gives the correct result up to the 20th term of the Lucas fuction. Added some basic assertion tests.
…roth and first terms to give the nth term of the Fibonacci series. Will give nth term of arbitrary series given users specified zeroth and first terms to work from. Some basic assertion tests to show it computes the correct nth term in the series and a docstring giving some details on what the function does.
Contributor
|
Thanks for putting in your lightning talk -- MPL is pretty nice! I do encourage you to take a look at the "OO interface", rather than "from pylab import *" -- the pylab interface is nice for quick interactive use, and is comfortable for Matlab folks, but makes for messy, hard to re-use code when you get bigger projects going... |
Contributor
There was a problem hiding this comment.
nice use of defined constants and string multiplication
PythonCHB
added a commit
that referenced
this pull request
Oct 13, 2014
Ian M. Davis Homework Love those docstrings! Very nicely done. One thing -- it's not really worth catching the AssertionErrors -- they will get hit anyway, so not a lot of value added. But good form for Exceptions in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homework for UW Intro to Python