Updated resolve_uri() and response_not_found()#116
Closed
maxmac12 wants to merge 3 commits intoUWPCE-PythonCert:masterfrom
Closed
Updated resolve_uri() and response_not_found()#116maxmac12 wants to merge 3 commits intoUWPCE-PythonCert:masterfrom
maxmac12 wants to merge 3 commits intoUWPCE-PythonCert:masterfrom
Conversation
There was a problem hiding this comment.
In this we have the implicit assumption that URI will always be an absolute path. What if it is not?
|
good work. I'll close this as reviewed. Feel free to leave questions here if you have any. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial check in of session #2 homework. For the most part it seems like resolve_uri() is working correctly except for when a directory is specified as the URI. When a directory is requested the function seems to correctly reply with a plain text list of all of the files within that directory. However, this list specifies absolute file paths instead of relative paths.
One big issue that I have been fighting are connection refusal errors which has been a roadblock for further development. Still trying to figure out why my connections are being refused when they seemed to be working fine at the end of the previous class.