-
Notifications
You must be signed in to change notification settings - Fork 651
Declare post collection params so they can be exposed #1302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WP-API/amigos What should I do with legacy get_allowed_query_vars() ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API has always supported the public query_vars of WP_Query, included a few others, and provided a filter to add support for additional vars. There are some public query vars that are pretty pointless (example withcomments) but trying to normalize all these params sounds like a headache to me.
|
@WP-API/amigos I'm not 100% sure what we decided to do with Given we don't support |
I don't know if we discussed this, but it sounds like we should. |
|
When we discussed this at LoopConf, I was under the impression we settled on the following:
That way, we can support WordPress devs thinking the a |
I dig this — seems like a reasonable compromise. |
|
If we're going to do it, keep the |
|
I dig |
|
Marking as Needs Refresh, since |
|
Closing in favor of #1793 |
See #924, #555