Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Drop orderby=>term_id; add tests for orderby=>id #1990

Merged
joehoyle merged 1 commit into from
Jan 11, 2016
Merged

Drop orderby=>term_id; add tests for orderby=>id #1990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/endpoints/class-wp-rest-terms-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,6 @@ public function get_collection_params() {
'name',
'slug',
'term_group',
'term_id',
'description',
'count',
),
Expand Down
33 changes: 33 additions & 0 deletions tests/test-rest-terms-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,39 @@ public function test_get_items_orderby_args() {
$this->assertEquals( 'Apple', $data[0]['name'] );
}

public function test_get_items_orderby_id() {
$tag0 = $this->factory->tag->create( array( 'name' => 'Cantaloupe' ) );
$tag1 = $this->factory->tag->create( array( 'name' => 'Apple' ) );
$tag2 = $this->factory->tag->create( array( 'name' => 'Banana' ) );
// defaults to orderby=name, order=asc
$request = new WP_REST_Request( 'GET', '/wp/v2/tags' );
$response = $this->server->dispatch( $request );
$this->assertEquals( 200, $response->get_status() );
$data = $response->get_data();
$this->assertEquals( 'Apple', $data[0]['name'] );
$this->assertEquals( 'Banana', $data[1]['name'] );
$this->assertEquals( 'Cantaloupe', $data[2]['name'] );
// orderby=id, with default order=asc
$request = new WP_REST_Request( 'GET', '/wp/v2/tags' );
$request->set_param( 'orderby', 'id' );
$response = $this->server->dispatch( $request );
$this->assertEquals( 200, $response->get_status() );
$data = $response->get_data();
$this->assertEquals( 'Cantaloupe', $data[0]['name'] );
$this->assertEquals( 'Apple', $data[1]['name'] );
$this->assertEquals( 'Banana', $data[2]['name'] );
// orderby=id, order=desc
$request = new WP_REST_Request( 'GET', '/wp/v2/tags' );
$request->set_param( 'orderby', 'id' );
$request->set_param( 'order', 'desc' );
$response = $this->server->dispatch( $request );
$data = $response->get_data();
$this->assertEquals( 200, $response->get_status() );
$this->assertEquals( 'Banana', $data[0]['name'] );
$this->assertEquals( 'Apple', $data[1]['name'] );
$this->assertEquals( 'Cantaloupe', $data[2]['name'] );
}

public function test_get_items_post_args() {
$post_id = $this->factory->post->create();
$tag1 = $this->factory->tag->create( array( 'name' => 'DC' ) );
Expand Down