ea63bdf

New-Test(302373@main): ASSERTION FAILED: !(blobSize % sizeof(T)) on TestWebKitAPI.IndexedDB.OpenDatabaseWithMismatchedMetadataVersionAndName
https://bugs.webkit.org/show_bug.cgi?id=301776
rdar://163819252

Reviewed by NOBODY (OOPS!).

The test case is covering a case where the user has an IDB database whose
IDB version is 2 but is still using the old encoding for Strings (due to
a bug we had in WebKit for a while). In this case, it tries to read the
database name string in the new format and gets "garbage" and then later
compared it with the expected name and if it doesn't match, there is logic
to handle the migration. The issue is that there is a debug assertion in
sqliteColumnBlob() which hits in debug when trying to read the database
name in the new format (which doesn't match the format on disk). Since
this is expected in this case, I am replacing the debug assertion with
an `if` check which returns an empty span in this case (which is strictly
better than returning "garbage") and it will keep the database upgrade
logic working as intended.

Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm

* Source/WebCore/platform/sql/SQLiteExtras.h:
(WebCore::sqliteColumnBlob):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm:
(TEST(IndexedDB, OpenDatabaseWithMismatchedMetadataVersionAndName)):

ea63bdf

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests	🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 wpe-cairo-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv-sim	✅ 🛠 mac-safer-cpp
	✅ 🛠 watch
	✅ 🛠 watch-sim