Skip to content

Start responsiveness timer for network process when deleting website data #56547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
szewai wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Start responsiveness timer for network process when deleting website data #56547

szewai wants to merge 1 commit into from
+36 −6

Conversation

@szewai
Copy link
Contributor

@szewai szewai commented Jan 14, 2026 •
edited by webkit-early-warning-system
Loading

496b849

Start responsiveness timer for network process when deleting website data
https://bugs.webkit.org/show_bug.cgi?id=305456
rdar://167415985

Reviewed by NOBODY (OOPS!).

Recent bug reports show that network process might hang during website data deletion. We don't know the cause yet. To
mitigate the impact, periodically (every 6 seconds) check whether network process is still responsive during website
data deletion; if it gets in to bad state and becomes unresponsive, it will be terminated and new process will be
relaunched.

* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteWebsiteDataImpl):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::performResponsivenessCheck):
(WebKit::NetworkProcessProxy::updateResponsivenessCheck):
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:

496b849

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@szewai
Start responsiveness timer for network process when deleting website …
496b849 
…data

https://bugs.webkit.org/show_bug.cgi?id=305456
rdar://167415985

Reviewed by NOBODY (OOPS!).

Recent bug reports show that network process might hang during website data deletion. We don't know the cause yet. To
mitigate the impact, periodically (every 6 seconds) check whether network process is still responsive during website
data deletion; if it gets in to bad state and becomes unresponsive, it will be terminated and new process will be
relaunched.

* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteWebsiteDataImpl):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::performResponsivenessCheck):
(WebKit::NetworkProcessProxy::updateResponsivenessCheck):
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
@szewai szewai self-assigned this Jan 14, 2026
@szewai szewai added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jan 14, 2026
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 14, 2026 •
edited
Loading

EWS run on current version of this PR (hash 496b849)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdumez cdumez Awaiting requested review from cdumez cdumez will be requested when the pull request is marked ready for review cdumez is a code owner

Assignees

@szewai szewai

Labels

merging-blocked Applied to prevent a change from being merged New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szewai @webkit-early-warning-system @webkit-ews-buildbot