Skip to content

Enable compiled sandbox profile caching in macCatalyst builds #56548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hortont424 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable compiled sandbox profile caching in macCatalyst builds #56548

hortont424 wants to merge 1 commit into from
+2 −1

Conversation

@hortont424
Copy link
Contributor

@hortont424 hortont424 commented Jan 14, 2026 •
edited by webkit-early-warning-system
Loading

c2ffa60

Enable compiled sandbox profile caching in macCatalyst builds
https://bugs.webkit.org/show_bug.cgi?id=305460
rdar://168126328

Reviewed by NOBODY (OOPS!).

Enable sandbox caching in macCatalyst builds. These builds use macOS style
sandbox profiles (loaded and applied at runtime, unlike iOS), and as such, benefit
from caching just like normal macOS WebKit.

This improves macCatalyst Web Process launch time by about 2 seconds (from 2.5s to 0.5s)
in my local testing.

* Source/WebKit/Configurations/WebKit.xcconfig:
* Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:

c2ffa60

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 loading-orange 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 loading 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@hortont424
Enable compiled sandbox profile caching in macCatalyst builds
c2ffa60 
https://bugs.webkit.org/show_bug.cgi?id=305460
rdar://168126328

Reviewed by NOBODY (OOPS!).

Enable sandbox caching in macCatalyst builds. These builds use macOS style
sandbox profiles (loaded and applied at runtime, unlike iOS), and as such, benefit
from caching just like normal macOS WebKit.

This improves macCatalyst Web Process launch time by about 2 seconds (from 2.5s to 0.5s)
in my local testing.

* Source/WebKit/Configurations/WebKit.xcconfig:
* Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:
@hortont424 hortont424 requested a review from emw-apple as a code owner January 14, 2026 08:45
@hortont424 hortont424 self-assigned this Jan 14, 2026
@hortont424 hortont424 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jan 14, 2026
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 14, 2026 •
edited
Loading

EWS run on current version of this PR (hash c2ffa60)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 loading-orange 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 loading 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@hortont424 hortont424 requested review from pvollan, smfr and whsieh January 14, 2026 08:45
aprotyas
aprotyas reviewed Jan 14, 2026
View reviewed changes
Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
Comment on lines 81 to 85
#if PLATFORM(MAC) || PLATFORM(MACCATALYST)
#define USE_CACHE_COMPILED_SANDBOX 1
#else
#define USE_CACHE_COMPILED_SANDBOX 0
#endif
Copy link
Member

@aprotyas aprotyas Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that we define this here rather than in PlatformUse.h, though

pvollan
pvollan approved these changes Jan 14, 2026
View reviewed changes
Copy link
Contributor

@pvollan pvollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aprotyas aprotyas aprotyas approved these changes

@pvollan pvollan pvollan approved these changes

@emw-apple emw-apple Awaiting requested review from emw-apple emw-apple is a code owner

@smfr smfr Awaiting requested review from smfr

@whsieh whsieh Awaiting requested review from whsieh

Assignees

@hortont424 hortont424

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hortont424 @webkit-early-warning-system @aprotyas @pvollan