Changes to support building from Linux#225
Merged
iangrunert merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
meson needed a couple of patches to support building lcms + harfbuzz icu needed additional patches
foopoiuyt
reviewed
Feb 8, 2026
ports/vcpkg-tool-meson/0002-Pass-fuse-ld-to-clang-cl-for-correct-linker-selectio.patch
Show resolved
Hide resolved
ports/vcpkg-tool-meson/0001-Detect-clang-cl-by-binary-name-on-non-Windows-hosts.patch
Show resolved
Hide resolved
| + | ||
| + /* When cross-compiling from a non-Windows host, the CMake build system | ||
| + * links the data library itself; skip the link/lib step here. */ | ||
| + const char *skipLink = getenv("ICU_SKIP_PKGDATA_LINK"); |
Contributor
There was a problem hiding this comment.
Would a command line option be better for this? It might be too much work to do the plumbing and hit all the places that call pkgdata, so it's fine if so, but it feels a bit weird to use the environment for this.
foopoiuyt
approved these changes
Feb 10, 2026
Contributor
foopoiuyt
left a comment
There was a problem hiding this comment.
I think maybe we eventually want to think about the pkgdata environment variable thing, but I don't think that needs to block things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meson needed a couple of patches to support building lcms + harfbuzz
icu needed additional patches
See WebKit/WebKit#57907 for the WebKit PR