Open
Conversation
donny-dont
commented
Apr 14, 2022
ports/gperf/CMakeLists.txt
Outdated
| cmake_minimum_required(VERSION 3.0) | ||
| cmake_minimum_required(VERSION 3.15) | ||
|
|
||
| set(CMAKE_SYSTEM_VERSION 8.1 CACHE TYPE INTERNAL FORCE) |
Contributor
Author
There was a problem hiding this comment.
This should probably be in the portfile right?
The gperf 3.2 release happened early this year but the release wasn't packaged on their ftp. Use a GitHub mirror of the sources instead. Build is modified to use a static runtime on Windows. It also targets Windows 8.1. This is to make sure that the executable runs within the docker-webkit-dev containers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gperf 3.2 release happened early this year but the release wasn't packaged on their ftp. Use a GitHub mirror of the sources instead.
Build is modified to use a static runtime on Windows. It also targets Windows 8.1. This is to make sure that the executable runs within the docker-webkit-dev containers.