Polish Custom HTML block #21711
Closed
Polish Custom HTML block #21711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.34 kB (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
a56040c to
a592b2a
Compare
b0de19b to
ae1b693
Compare
fa9d1e2 to
4de241c
Compare
4de241c to
068f6d3
Compare
Member
|
Thanks for iterating here @ZebulanStanphill. My main wonder is about the unselected state. It feels a little strong and I wonder if the border is needed? |
Member
Author
|
@karmatosed Since the Custom HTML block in non-preview mode isn't representative of the front-end, I figured I should make it stand out using the same borders as the block toolbar and placeholders, to make it clear that it's part of the block UI, not the content. |
7e4037e to
c16ca14
Compare
Contributor
Could this add some confusion by making it look like the 'Edit as HTML' mode? I feel these two are different things, one is a block, the other is an editing mode and should look different, no? |
Member
Author
|
@enriquesanchez Functionally, they're exactly the same. In both cases, you're editing the HTML of the block. I see no reason to style them differently. |
c16ca14 to
f550b64
Compare
Member
Author
c0864b7 to
8059cd6
Compare
Member
Author
|
Changed styles again to match the latest "Edit as HTML" style introduced in #25539. |
8059cd6 to
e9a83b6
Compare
6 tasks
75ac705 to
6d7fa5b
Compare
Member
Author
|
Rebased after the changes in #26055. |
6d7fa5b to
3722db3
Compare
3722db3 to
edefa6c
Compare
edefa6c to
1c73c3d
Compare
1c73c3d to
d7e5080
Compare
Member
Author
|
Several of the changes in this PR have already made it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR polishes the Custom HTML block. Notable changes:
PlainTextv1 to usingTextareaAutosizedirectly.defaultStylesinto a constant defined outside of the component, so it doesn't get recreated every time theuseSelectcallback runs.wp-block-htmlCSS class toblock-library-html.components-tab-buttonCSS class that appears to have no visible effect or purpose.margin-bottomeditor style.Screenshots
Unselected
Before
After
Selected; textarea NOT focused
Before
After
Selected; textarea focused
Before
After
Navigation mode AKA select tool
Before
After
Checklist: