Enhancement: Display a Button Appender when Buttons block is empty #38337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a Twitter conversation with @heathergray (closes #38338), it looks like the lack of a visual cue that the
Buttonsblock is still in the editor, seems to cause confusion for more than one person. Although, upon refreshing theButtonsblock auto populates with an emptyButtonblock, it can be frustrating not realizing that deleting theButtonblock doesn't mean you've deleted theButtonsparent block.Description
To solve this issue, I've changed the
Buttonsblock just slightly, to show theButton Appenderwhen the block is empty, making it easy to see that theButtonsblock is still in the editor, you can easily select it to delete/add/etc.Testing Instructions
ButtonsblockButtonblocksButtonsblock is empty.Screenshots
Screen.Recording.2022-01-28.at.10.37.30.AM.mov
Types of changes
When empty, the
Buttonsblock displays theButton Appenderto indicate its existence.Checklist:
*.native.jsfiles for terms that need renaming or removal).