Skip to content

Conversation

@DaisyOlsen
Copy link
Contributor

The docs page added in #48265 had a markdown table - this needs to be an HTML table instead to get the content out to the Handbook page. Currently, it's a blank page.

@DaisyOlsen DaisyOlsen added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers labels Mar 9, 2023
@DaisyOlsen DaisyOlsen requested a review from justintadlock March 9, 2023 18:43
@DaisyOlsen DaisyOlsen requested a review from ajitbohra as a code owner March 9, 2023 18:43
@DaisyOlsen DaisyOlsen self-assigned this Mar 9, 2023
@DaisyOlsen DaisyOlsen changed the title Reformat with an HTML template. Reformat styles options by version page with an HTML template. Mar 9, 2023
@fabiankaegy
Copy link
Member

@DaisyOlsen Thanks for this PR :)

Looking at the page on the Handbook I see the table rendering correctly though: https://developer.wordpress.org/block-editor/reference-guides/theme-json-reference/styles-versions/ Or are you talking about another page? 🤔

Also looking at some other pages that contain tables like this one here:

| Gutenberg Versions | WordPress Version |
They also use markdown tables and render fine.

@DaisyOlsen
Copy link
Contributor Author

Thanks for looking! Not sure why it wasn't showing for me last week. I confirmed that is good as-is and will close this out.

@DaisyOlsen DaisyOlsen closed this Mar 13, 2023
@DaisyOlsen DaisyOlsen deleted the fix-themejson-styles-docs branch March 13, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants