Update nofollow control label #54184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
getdave
reviewed
Sep 5, 2023
Contributor
getdave
left a comment
There was a problem hiding this comment.
Thank you for the PR. Much appreciated.
Some tweaks needed and then we're good to go.
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
getdave
reviewed
Sep 5, 2023
Co-authored-by: Dave Smith <getdavemail@gmail.com>
getdave
reviewed
Sep 5, 2023
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Contributor
|
Not sure what happened. We lost the removal of the |
Restore origin wording
getdave
approved these changes
Sep 5, 2023
Contributor
getdave
left a comment
There was a problem hiding this comment.
Ok approving on the basis of wording being:
Mark as nofollow
And tests being left "as is". I think we can revert all the changes to the test files before merging.
Contributor
Author
First-time collaboration between us 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Address issue raised on #54179 cc: @getdave
Why?
Code tags on label causing a11y issue
How?
Testing Instructions
Kapture.2023-09-05.at.17.19.28.mp4
Testing Instructions for Keyboard
Screenshots or screencast