Skip to content

Conversation

@Vrishabhsk
Copy link
Contributor

@Vrishabhsk Vrishabhsk commented Oct 23, 2024

Fixes #66322

What?

Why?

How?

  • Change text-color for post list title and post card title badge to $gray-800

Screenshots or screencast

Posts Page Homepage Posts List
Screenshot 2024-10-23 at 12 59 42 PM Screenshot 2024-10-23 at 12 59 49 PM Screenshot 2024-10-23 at 12 59 59 PM

@github-actions
Copy link

github-actions bot commented Oct 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Vrishabhsk <vrishabhsk@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor [Package] Edit Site /packages/edit-site labels Oct 23, 2024
@afercia
Copy link
Contributor

afercia commented Oct 23, 2024

From an accessibility perspective, looks good to me.
Cc @WordPress/gutenberg-design for feedback on the visual change.

@jameskoster
Copy link
Contributor

Thank you.

Side note: it would be good to create a component for badges.

@afercia
Copy link
Contributor

afercia commented Oct 24, 2024

Side note: it would be good to create a component for badges.

Thanks for your feedback @jameskoster. I'd totally support standardising badges in a component if there are plans to use them more often.

@afercia afercia merged commit 9c7847d into WordPress:trunk Oct 24, 2024
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 24, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
)


Co-authored-by: Vrishabhsk <vrishabhsk@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Insufficient color contrast for the post list title badge and the post card title badge

3 participants