Skip to content

Conversation

@Vrishabhsk
Copy link
Contributor

What?

Why?

  • When the user is offline, the search prodiuces a 500 error code, the Infinity Spinner is not hidden
  • The Spinner should be hidden once the request fails, and should render the relevant placeholder

How?

  • Return empty array in the place of blocks in the error part of the trycatch block

Screenshots or screencast

Before After
Screenshot 2025-01-10 at 5 30 28 PM Screenshot 2025-01-10 at 5 27 54 PM

@github-actions
Copy link

github-actions bot commented Jan 10, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Vrishabhsk <vrishabhsk@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Block Directory Related to the Block Directory, a repository of block plugins labels Jan 11, 2025
@Mamaduka Mamaduka added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Jan 12, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Jan 12, 2025
@Mamaduka Mamaduka merged commit cd8e655 into WordPress:trunk Jan 13, 2025
63 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 13, 2025
Gulamdastgir-Momin pushed a commit to Gulamdastgir-Momin/gutenberg that referenced this pull request Jan 23, 2025
…8600)


Co-authored-by: Vrishabhsk <vrishabhsk@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…8600)


Co-authored-by: Vrishabhsk <vrishabhsk@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Block Directory Related to the Block Directory, a repository of block plugins [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants