Skip to content

Rename aspect property to ratio to carry the defaultAspect in AspectRatioDropdown #69085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mamaduka merged 1 commit into from
Feb 12, 2025
Merged

Rename aspect property to ratio to carry the defaultAspect in AspectRatioDropdown #69085

Mamaduka merged 1 commit into from
Feb 12, 2025

Conversation

@yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Feb 7, 2025 •
edited
Loading

What, Why and How?

Closes #69084

This PR fixes an issue where selecting Original Ratio while cropping an image applies an incorrect ratio to the Image block. Additionally, since Original Ratio represents the default state, it should be pre-selected by default.

Testing Instructions

  1. Create an Image Block and pick an Image.
  2. From the Toolbar Controls toggle Crop then Aspect Ratio.
  3. Choose Original from Aspect Ratio.
  4. Confirm that the Image now properly reflects to the Original ratio.

Screencast

pr-demo-enhanced.mov

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review February 7, 2025 07:14
@github-actions
Copy link

github-actions bot commented Feb 7, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: mikinchauhan <mikinc860@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Package] Block editor /packages/block-editor labels Feb 9, 2025
@Mamaduka Mamaduka self-requested a review February 9, 2025 08:10
@yogeshbhutkar
Copy link
Contributor Author

yogeshbhutkar commented Feb 11, 2025

The AspectRatioGroup component was refactored in PR #47271, but the following line was missed and should also be updated from aspect to ratio:

gutenberg/packages/block-editor/src/components/image-editor/aspect-ratio-dropdown.js

Line 96 in e850c68

aspect: defaultAspect,

Additionally, the failing tests are unrelated to the changes introduced in this PR.

@mikinchauhan
Copy link

mikinchauhan commented Feb 11, 2025

I connected my Git account to my profile.

@Mamaduka
Copy link
Member

Mamaduka commented Feb 11, 2025

@yogeshbhutkar, rebasing on top of the latest trunk should resolve the e2e test issue.

Mamaduka
Mamaduka approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected ✅

@Mamaduka Mamaduka merged commit a507759 into WordPress:trunk Feb 12, 2025
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.3 milestone Feb 12, 2025
Kallyan01 pushed a commit to Kallyan01/gutenberg that referenced this pull request Feb 24, 2025
@yogeshbhutkar @Mamaduka @Kallyan01
Rename aspect to ratio to carry the defaultAspect (WordPress#69085
5761f78 
)


Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: mikinchauhan <mikinc860@git.wordpress.org>
@yogeshbhutkar yogeshbhutkar deleted the fix-69084/typo-in-crop branch March 18, 2025 08:44
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
@yogeshbhutkar @Mamaduka @chriszarate
Rename aspect to ratio to carry the defaultAspect (WordPress#69085
5ec2caf 
)


Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: mikinchauhan <mikinc860@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

Assignees

No one assigned

Labels

[Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 20.3

Development

Successfully merging this pull request may close these issues.

Selecting "Original Ratio" while cropping an image does not properly reset it.

3 participants

@yogeshbhutkar @mikinchauhan @Mamaduka