Skip to content

Quote block: Fix group transform behavior #70174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sukhendu2002 wants to merge 1 commit into from
Closed

Quote block: Fix group transform behavior #70174

Sukhendu2002 wants to merge 1 commit into from

Conversation

@Sukhendu2002
Copy link
Contributor

@Sukhendu2002 Sukhendu2002 commented May 21, 2025 •
edited
Loading

What?

Closes: #58042

Fixes an issue where grouping a Quote block would transform it into a Group block with the quote content converted to a Paragraph block.

Why?

When users select the "Group" option from a Quote block's toolbar, the current behavior transforms the Quote block into a Group block and converts the quote content to a Paragraph block. This is unexpected behavior - the Quote block should be wrapped in a Group block while maintaining its original structure.

Testing Instructions

  1. Add a Quote block to the editor
  2. Add some content and a citation
  3. Select the Quote block
  4. Click the "Group" option from the block toolbar
  5. Verify:
    • The Quote block is now wrapped in a Group block
    • The quote content remains a Quote block (not converted to Paragraph)
    • The citation is preserved
    • All formatting is maintained

Screenshots or screencast

Screen.Recording.2025-05-21.at.1.28.46.PM.mov

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review May 21, 2025 08:00
@github-actions
Copy link

github-actions bot commented May 21, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
Co-authored-by: bacoords <bacoords@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Feature] Block Transforms Block transforms from one block to another [Block] Quote Affects the Quote Block labels May 21, 2025
@Mamaduka
Copy link
Member

Mamaduka commented May 21, 2025

Thanks for working on this, @Sukhendu2002!

Unfortunately, I don't think there's a consensus on how to resolve this problem. For similar issues, I would recommend continuing the discussion in the ticket until it becomes actionable.

Technical note

You can remove the transformation in question, and the block editor will default to the wildcard transformation just like other blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

No one assigned

Labels

[Block] Quote Affects the Quote Block [Feature] Block Transforms Block transforms from one block to another [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Grouping a single Quote block transforms it (instead of grouping it)

2 participants

@Sukhendu2002 @Mamaduka