Fix: render_block_core_site_title function doc has missing return type #70269
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @OpuRockey! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Maybe we should change this line and return an empty string instead: |
…e -- Return empty string instead of simple return back
WordPress#70269) Co-authored-by: OpuRockey <opurockey@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
What?
Closes #70268
Why?
render_block_core_site_titlefunction doc should be updated. Though the return type is set string, it also return null on line 20;if ( ! trim( $site_title ) ) { return; }How?
I have updated the doc as per return type.
Screenshots or screencast