Add email validation for ip addresses #70709
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @rjchow. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
- Remove support for short domains (e.g., `@example`, `@123456789`) - Remove IPv6 address support in email domains starting without `IPv6:` - Require domains to have at least two labels separated by dots - Clean up unused IPv6-related constants and functions
b5e8f0e to
5ddf611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #38105
This PR replaces and continues the work from #38758, which appears to have become stale.
Thank you @ediamin for creating the initial PR with great start and this PR hopes to continue of that effort and addresses the edge cases mentioned in discussions.
Why?
WordPress
is_emailvalidates emails that are in format ofemail@<ip-address>while@wordpress/url's isEmail returns false for the same.This PR adds supports for that.
How?
This PR adds support for this by creating
IP_PATTERNwhich validates ip address and and extendsEMAIL_REGEXto use that.Testing Instructions
Unit test's include email with ip addresses and they should suffice
Screenshots or screencast