Fix: Nested tag handling while pasting content from external sources #70823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace DOM-based approach with string-level regex preprocessing - Add shared flattenNestedTags utility to eliminate code duplication - Fix both external paste (pasteHandler) and internal copy-paste (rich-text event listeners) - Add comprehensive test coverage for utility function and integration scenarios - Handle nested strong and anchor tags before DOM parsing to prevent browser auto-correction issues
- Add logic to detect when pasted content contains links - Filter out link formats from activeFormats when pasting linked content - Prevent nested <a> tags when pasting links into existing links - Add null check and validation in flattenNestedTags utility - Export flattenNestedTags from @wordpress/blocks for reuse - Remove debug console logging - All tests passing (16/16)
- Remove unnecessary complex string-based regex processing - Remove flattenNestedTags function and related code - Keep only the essential fix: filter link formats from activeFormats when pasting linked content - This prevents nested <a> tags with minimal code changes - All existing tests still pass
…r & restore console.log
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #70542
Why?
This PR handles pasted links to avoid nested anchor tags, which earlier led to invalid HTML markup
How?
While pasting links, if the target is already enclosed in
<atags, anchor tags are stripped from the copied text to avoid pasting anchor tags againSimilar approach can be used to tackle other HTML tags, but since anchor tags lead to invalid HTML, it is targetted first
Approach will be expanded based on discussion in #70542
Testing Instructions
Screenshots or screencast
Before
Screen.Recording.2025-08-04.at.7.02.43.PM.mov
After
Screen.Recording.2025-08-04.at.7.05.42.PM.mov